fix URI handling on windows #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilpa
approved these changes
Mar 11, 2020
|
Apparently I can commit directly to the PR. I added the comment since I may follow up at sometime to implement full support (or more likely find a small lib that does the right thing here). Thanks again! Hopefully this is more useful for you on Windows now. |
|
I cut a |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URI handling of filenames on windows is broken so the tool is unusable on windows. This bugfix closes #1
This fix is probably not formally correct for all corner cases in windows file handling but should work for all standard cases.